Skip to content

Conversation

@GerjanDorgelo
Copy link
Contributor

@GerjanDorgelo GerjanDorgelo commented Feb 6, 2026

Description

feature request add torsion steel check. must be checked after Shear has been added as i use features introduced there.
Please note: only features St. Venant torsion. Warping torsion is horrible and needs 3d FEM.

image

As Blueprints uses different coordinates than sectionproperties. see for converstion above.

Fixes #966

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

…istance checks and enhance Report class with equation splitting functionality
…vironments and rename split_on to split_after for clarity
@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 966-feature-request-add-torsion-steel-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ca0b6ab) to head (c164736).
⚠️ Report is 1 commits behind head on 840-feature-request-add-first-steel-check-to-blueprints.

Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           840-feature-request-add-first-steel-check-to-blueprints      #968    +/-   ##
==========================================================================================
  Coverage                                                   100.00%   100.00%            
==========================================================================================
  Files                                                          422       425     +3     
  Lines                                                        13145     13386   +241     
==========================================================================================
+ Hits                                                         13145     13386   +241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GerjanDorgelo GerjanDorgelo self-assigned this Feb 7, 2026
@GerjanDorgelo GerjanDorgelo changed the title 966 feature request add torsion steel check PART 4 - 966 feature request add torsion steel check Feb 7, 2026
…ethod-in-steel-cross-section' into 960-feature-request-add-plastic-shear-check-for-i-profiles
…nd improve stress calculation in CheckStrengthShearClass34
…les' into 966-feature-request-add-torsion-steel-check
…heckStrengthTorsionShearClass34 for class 3 and 4 sections
Base automatically changed from 840-feature-request-add-first-steel-check-to-blueprints to main February 11, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant